Skip to content

Add an option to cmsTraceFunction to abort with non-zero exit code on first breakpoint#20

Merged
smuzaffar merged 1 commit into
cms-sw:masterfrom
makortel:cmsTraceFunctionAbort
Sep 1, 2025
Merged

Add an option to cmsTraceFunction to abort with non-zero exit code on first breakpoint#20
smuzaffar merged 1 commit into
cms-sw:masterfrom
makortel:cmsTraceFunctionAbort

Conversation

@makortel
Copy link
Copy Markdown
Contributor

@makortel makortel commented Aug 21, 2025

In the context of cms-sw/cmssw#46002, following discussion in core software meeting last week this PR adds --abort option to cmsTraceFunction to terminate the trace with non-zero exit code on the first function breakpoint. This option should make it easier to catch the problems in DEVEL IBs (or wherever we end up using the tracing) without separate log parsing.

Resolves cms-sw/framework-team#1526

@cmsbuild
Copy link
Copy Markdown

A new Pull Request was created by @makortel for branch master.

@akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown

cmsbuild commented Aug 21, 2025

cms-bot internal usage

@makortel
Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8ce3a/47824/summary.html
COMMIT: 2fe1952
CMSSW: CMSSW_15_1_X_2025-08-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-common/20/47824/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 17 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4075471
  • DQMHistoTests: Total failures: 142
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4075309
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 17316.850999999988 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 468.023 KiB Hcal/DigiTask
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Copy Markdown
Contributor Author

test parameters:

  • addpkg = Utilities/ReleaseScripts

@makortel
Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

Let's see if this works as I expect

@cmsbuild
Copy link
Copy Markdown

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8ce3a/47826/summary.html
COMMIT: 2fe1952
CMSSW: CMSSW_15_1_X_2025-08-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-common/20/47826/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 20 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4075471
  • DQMHistoTests: Total failures: 143
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4075308
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 17316.850999999988 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 468.023 KiB Hcal/DigiTask
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Copy Markdown
Contributor Author

The test-cmsTraceFunction-setenv unit test succeeded. Comparison differences are spurious.

@smuzaffar
Copy link
Copy Markdown
Contributor

+externals

@smuzaffar smuzaffar merged commit ac5bdc6 into cms-sw:master Sep 1, 2025
9 checks passed
@cmsbuild
Copy link
Copy Markdown

cmsbuild commented Sep 1, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@makortel makortel deleted the cmsTraceFunctionAbort branch September 2, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to cmsTraceFunction to exit with non-zero exit code after hitting a breakpoint

3 participants